Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile does not install static library if only make install is called #662

Closed
aavbsouza opened this issue Apr 4, 2022 · 1 comment · Fixed by #663
Closed

Makefile does not install static library if only make install is called #662

aavbsouza opened this issue Apr 4, 2022 · 1 comment · Fixed by #663

Comments

@aavbsouza
Copy link

Hello, some libraries for instance HPCCM (https://github.com/NVIDIA/hpc-container-maker/blob/6c984440702525624b71f827d4f5126ce174ab2f/hpccm/building_blocks/nccl.py#L156) only calls make install, but since the install target only depends on the lib target the static library is not created. A possible solution is to make install depends on the build target.
sjeaugey added a commit that referenced this issue Apr 4, 2022
@sjeaugey
Update Makefile to install static library.
b523cff 
Make sure make install also installs the static library. 
Fixes #662
@sjeaugey sjeaugey mentioned this issue Apr 4, 2022
Merged
@sjeaugey
Copy link
Member

sjeaugey commented Apr 4, 2022

That sounds like a good idea. I made a PR for that.

sjeaugey added a commit that referenced this issue Apr 8, 2022
@sjeaugey
Update Makefile to install static library.
9bfc1c6 
Make sure make install also installs the static library. 
Fixes #662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Makefile to install static library. NVIDIA/nccl
2 participants
@sjeaugey @aavbsouza