Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local integration for turbine force #114

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Local integration for turbine force #114

merged 4 commits into from
Mar 12, 2024

Conversation

jefalon
Copy link
Collaborator

@jefalon jefalon commented Mar 1, 2024

Purpose

This PR adds the feature to create a local integration bubble around each turbine allowing for quicker assemblies. It works by marking the mesh cell in a sphere around each turbine and then labeling them. This way, when integrating or assembling the A matrix, FEniCS only need to assemble a small cluster of DOF per turbine rather than the full global domain. Since the turbine function rapidly go to zero, this approximation should be sound while saving significant compute time.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

The approximation is so good that all the current CI test work using this new integration except for the ALMx2_Unsteady case.

Checklist

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have verified my code additions work in parallel
  • I have added necessary documentation

@jefalon jefalon merged commit 51adbca into NREL:dev Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant