Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tracking of REopt.jl runs with PV and Wind from api.data.gov #428

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

Bill-Becker
Copy link
Collaborator

  • Add header User-Agent=REopt.jl to PVWatts and Wind Toolkit API requests
    • This enables tracking of REopt.jl usage from within the api.data.gov platform, with admin monitoring access to the PVWatts and Wind Toolkit API's on api.data.gov
    • (Suggestion by Nick Muerdter for quick ability to track, including by user from the user's API key, even if for only when the users are using the PVWatts or Wind Toolkit APIs for production factor)

@Bill-Becker Bill-Becker requested a review from adfarth July 29, 2024 03:06
@adfarth
Copy link
Collaborator

adfarth commented Aug 9, 2024

@Bill-Becker is it intentional to merge this directly into master?

Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bill-Becker I'm assuming that since the tests pass this change won't cause any issues, but let me know if there's something else you think is worth testing. Also flagging that this is set to merge directly into master, in case that was unintentional.

@Bill-Becker Bill-Becker changed the base branch from master to develop August 9, 2024 20:17
@Bill-Becker
Copy link
Collaborator Author

@Bill-Becker is it intentional to merge this directly into master?

Nope! Changed to develop.

@Bill-Becker Bill-Becker merged commit ea662fa into develop Aug 9, 2024
3 of 5 checks passed
@Bill-Becker Bill-Becker deleted the api-track branch August 9, 2024 20:18
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Enable tracking of REopt.jl runs with PV and Wind from api.data.gov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants