Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PR 775 and 789, and make them conditional on 786 #796

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

JurgenZach-NOAA
Copy link
Contributor

@JurgenZach-NOAA JurgenZach-NOAA commented Jul 4, 2024

This PR is a continuation of PR 775 and incorporates the modifications (removal of some initial outputs) applied in PR 789. In addition, the PR is aligned with PR 786 in that the new kernel execution log file is generated whenever the new "log directory" is uncommented, with the output going into the same folder.

Additions

  • Write key parameters, as actually processed by troute, to a separate log file - including, but not limited to:
    ++ MC network
    ++ Diffusive routing (if applicable) and network
    ++ Gages/data assimilation
    ++ Output of results
    ++ Key compute parameters

Removals

Changes

Testing

  1. Run Lower Colorado v4 test with line 41 in the config yaml file uncommented:

    log_directory : Log/

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@@ -1115,6 +1171,40 @@ def nwm_route(
else:
LOG.info(f"executing routing computation ...")

if (firstRun):
compute_log_mc(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it throw an error on this line that NameError: name 'compute_log_mc' is not defined.
( in yaml file, uncomment log_directory : Log/ and check it out)

@JurgenZach-NOAA JurgenZach-NOAA merged commit 6bb6f1b into NOAA-OWP:master Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants