Improve Cython dependency version specificity
#784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
approved these changes
Jun 13, 2024
This was referenced Jul 8, 2024
aaraney
added a commit
to aaraney/DMOD
that referenced
this pull request
Jul 12, 2024
Fix how `troute.nwm` is built. NOAA-OWP/t-route#784 removed `setup.py`, as a result the package should now be built with `build`.
This was referenced Jul 12, 2024
robertbartel
pushed a commit
to NOAA-OWP/DMOD
that referenced
this pull request
Jul 12, 2024
Fix how `troute.nwm` is built. NOAA-OWP/t-route#784 removed `setup.py`, as a result the package should now be built with `build`.
JurgenZach-NOAA
added a commit
that referenced
this pull request
Jul 25, 2024
Possible Cython compile errors in T-route caused by PR784 (#784) have resulted in a recommendation to compile in "no-editable' mode (PR 801, #801). The no-e option, in turn, has resulted in the necessity to recompile T-route after each edit of python code. The instructions provided here showcase how T-route can be installed in a manner compatible with PR 784 while avoiding the non-editable compile option. It is based on pip and venv, avoiding conda altogether. It has been implemented on WSL, but should be readily adaptable to the same recent long-term stable Ubuntu distros (22.04 and 20.04).
21 tasks
JurgenZach-NOAA
added a commit
that referenced
this pull request
Jul 25, 2024
Possible Cython compile errors in T-route caused by PR784 (#784) have resulted in a recommendation to compile in "no-editable' mode (PR 801, #801). The no-e option, in turn, has resulted in the necessity to recompile T-route after each edit of python code. The instructions provided here showcase how T-route can be installed in a manner compatible with PR 784 while avoiding the non-editable compile option. It is based on pip and venv, avoiding conda altogether. It has been implemented on WSL, but should be readily adaptable to the same recent long-term stable Ubuntu distros (22.04 and 20.04).
21 tasks
JurgenZach-NOAA
added a commit
that referenced
this pull request
Jul 29, 2024
* Included pip & venv based instructions for WSL2 (#812) Possible Cython compile errors in T-route caused by PR784 (#784) have resulted in a recommendation to compile in "no-editable' mode (PR 801, #801). The no-e option, in turn, has resulted in the necessity to recompile T-route after each edit of python code. The instructions provided here showcase how T-route can be installed in a manner compatible with PR 784 while avoiding the non-editable compile option. It is based on pip and venv, avoiding conda altogether. It has been implemented on WSL, but should be readily adaptable to the same recent long-term stable Ubuntu distros (22.04 and 20.04). * Updated shell formatting * Update readme.md * Update readme.md * Only clone single branch * Included warning about mixing pip and conda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython==3.0.4introduced an issue that causedt-routebuilding to fail (see #675). Newer version ofCythonhave been released and address the issue present in3.0.4. This PR makest-route'sCythonversion dependency requirement more lenient -- meaning more versions are now accepted to buildt-route. Specifically,Cython>3,!=3.0.4.Several other small backwards compatible packaging improvements were also introduced.
Fixes #675