-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BMI restart and lastobs files #654
BMI restart and lastobs files #654
Conversation
…lowpaths furthest downstream
@@ -247,6 +253,9 @@ def __init__(self, | |||
value_dict, | |||
bmi_parameters, | |||
) | |||
#FIXME: See FIXME above. | |||
if not from_files_copy: | |||
from_files=False | |||
|
|||
# Preprocess network objects | |||
self.preprocess_network(flowpaths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At L269, after changing use_preprocessed_data to False, I got an error saying that
PermissionError: [Errno 13] Permission denied: '/home/APD/inland_hydraulics/Apr2023_testcase/preprocess/Extended_AnA_output.npy'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a permissions issue on apd-dev, not necessarily a t-route issue. But curious why that came up. Do you have preprocess_only:
set to True
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put False to both preprocess_only and use_preprocessed_data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At Line406 in HYFeaturesNetwork.py, some lake id with NaN values of the attributes of Lakes layer of gpkg should be removed not to cause an error here:
https://github.com/shorvath-noaa/t-route/blob/14926225cacb5e4d773916913fc3956f1436c835/src/troute_model.py#L520-L523
The reason of the error is that lakes with such NaN values don't seem to have computed results in wbdy so that there are no id of such lakes in wbdy.
Add functionality to pass info pertaining to restart and lastobs files from troute_model to DAforcing_model, which in turn can write/read appropriate files.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other