Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MOS-1414): Remove PanelController from container if Profiler is unavailable. #17

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(MOS-1414): Remove PanelController from container if Profiler is unavailable. #17

merged 2 commits into from
Mar 14, 2024

Conversation

TomPeters-NL
Copy link

😭 Issue

When loaded outside of dev environments, the bundle throws an error, as the profiler service is not available outside the dev environments.

😍 Solution

This PR introduces a CompilerPass class that removes the PanelController from the container if the profiler service is not available.

@TomPeters-NL TomPeters-NL added the bug Something isn't working label Mar 14, 2024
@TomPeters-NL TomPeters-NL requested a review from a team March 14, 2024 10:17
@TomPeters-NL TomPeters-NL merged commit 82837c4 into 1.7 Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartvanraaij bartvanraaij bartvanraaij approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomPeters-NL @bartvanraaij