[TASK] Drop support for PHP 7.0 #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
reviewed
Jun 12, 2020
| @@ -37,7 +37,7 @@ | |||
| "source": "https://github.com/MyIntervals/emogrifier" | |||
| }, | |||
| "require": { | |||
| "php": "~7.0 || ~7.1 || ~7.2 || ~7.3 || ~7.4", | |||
| "php": "~7.1 || ~7.2 || ~7.3 || ~7.4", | |||
There was a problem hiding this comment.
Noting that the .0 point version suffix should be restored at some point so the behaviour is actually as intended (though there will not be a PHP 7.5).
JakeQZ
approved these changes
Jun 12, 2020
|
The CI tests seemed to get stuck waiting for Lint and unit tests for PHP 7.0, but that's now resolved - ? |
|
They still seem to get executed in #881. I have no idea why. |
Something being cached? Or is there any relevant GitHub configuratoin for the project that is external to the files visible within the source tree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.