Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Stop caching the vendor/ directory on Travis CI #848

Closed
wants to merge 1 commit into from

Conversation

oliverklee
Copy link
Contributor

Having this directory cached between builds can result in incorrect
versions of dependencies getting installed.

For a good build performance, caching the Composer cache directory
should suffice.

Having this directory cached between builds can result in incorrect
versions of dependencies getting installed.

For a good build performance, caching the Composer cache directory
should suffice.
@oliverklee oliverklee added the bug label Mar 27, 2020
@oliverklee oliverklee added this to the 4.0.0 milestone Mar 27, 2020
@oliverklee oliverklee requested review from zoliszabo and JakeQZ March 27, 2020 14:06
@oliverklee oliverklee self-assigned this Mar 27, 2020
@oliverklee
Copy link
Contributor Author

Currently, the Travis build status is not automatically visible in this PR.
Here's the direct link to the build:
https://travis-ci.org/github/MyIntervals/emogrifier/builds/667723113

@oliverklee
Copy link
Contributor Author

Closing. After #846, this will not be needed anymore.

@oliverklee oliverklee closed this Mar 28, 2020
@oliverklee oliverklee deleted the bugfix/travis-cache branch March 28, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant