Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Drop support for PHP 5.6 #773

Merged
merged 2 commits into from
Oct 1, 2019
Merged

[TASK] Drop support for PHP 5.6 #773

merged 2 commits into from
Oct 1, 2019

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Oct 1, 2019 •
edited
Loading

Now PHP >= 7.0 is required.

Changes to the code and to the php-cs-fixer configuration will come
in separate changes.

@oliverklee
[TASK] Drop support for PHP 5.6
25949ac 
Now PHP >= 7.0 is required.

Changes to the code and to the php-cs-fixer configuratoin will come
in separate changes.
@oliverklee oliverklee added this to the 4.0.0 milestone Oct 1, 2019
@oliverklee oliverklee requested review from zoliszabo and JakeQZ October 1, 2019 18:39
@oliverklee oliverklee self-assigned this Oct 1, 2019
@oliverklee oliverklee mentioned this pull request Oct 1, 2019
Merged
JakeQZ
JakeQZ requested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a ^ should be in the slevomat/coding-standard version constraint...

@JakeQZ JakeQZ merged commit 4ded527 into master Oct 1, 2019
@JakeQZ JakeQZ deleted the task/drop-php5.6 branch October 1, 2019 19:02
@oliverklee oliverklee mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ