[TASK] Test :nth-last-child #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the regex for supported pseudo-classes (`PSEUDO_CLASS_MATCHER`) so that those supported are explicitly specified (rather than ‘anything ending with `-child` or anything ending with `-type(`’), without acually affecting the valid pseudo-class names it will match. Except in the `Emogrifier` class – this doesn’t support `:nth-last-child` so that has been removed (to the effect that rules with it will now be copied to the `<style>` element rather than attempted to be inlined). And added `:nth-last-child` to the list of supported pseudo-classes in the README. (Also, for consistency, added `()` to the other `:nth…` pseudo-classes in that section.) Part of #747.
JakeQZ
commented
Sep 29, 2019
| @@ -6,6 +6,9 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| ## x.y.z | |||
|
|
|||
| ### Added | |||
| - Test `:nth-last-child` | |||
There was a problem hiding this comment.
Thinking about it, it's not just tests being added. These are new features by virtue of the Symfony CssSelector component. So these last 3 CHANGELOG entries should in fact read “Support and test …”. I can change that in a separate PR.
oliverklee
approved these changes
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the regex for supported pseudo-classes (
PSEUDO_CLASS_MATCHER) sothat those supported are explicitly specified (rather than ‘anything ending with
-childor anything ending with-type(’), without acually affecting the validpseudo-class names it will match. Except in the
Emogrifierclass – thisdoesn’t support
:nth-last-childso that has been removed (to the effect thatrules with it will now be copied to the
<style>element rather than attemptedto be inlined).
And added
:nth-last-childto the list of supported pseudo-classes in theREADME. (Also, for consistency, added
()to the other:nth…pseudo-classesin that section.)
Part of #747.