Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Rename HtmlPruner::removeInvisibleNodes … #718

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Sep 17, 2019

… to removeElementsWithDisplayNone.

Resolves #717.

@JakeQZ JakeQZ added the cleanup label Sep 17, 2019
@JakeQZ JakeQZ added this to the 3.0.0 milestone Sep 17, 2019
@JakeQZ JakeQZ self-assigned this Sep 17, 2019
… to `removeElementsWithDisplayNone`.

Resolves #717.
@JakeQZ JakeQZ force-pushed the cleanup/rename-remove-invisible-nodes branch from 1ffddbd to 897cef2 Compare September 17, 2019 15:56
@JakeQZ JakeQZ changed the title Rename HtmlPruner::removeInvisibleNodes … [CLEANUPRename HtmlPruner::removeInvisibleNodes … Sep 17, 2019
@JakeQZ JakeQZ changed the title [CLEANUPRename HtmlPruner::removeInvisibleNodes … [CLEANUP] Rename HtmlPruner::removeInvisibleNodes … Sep 17, 2019
@oliverklee oliverklee merged commit fabcc48 into master Sep 17, 2019
@oliverklee oliverklee deleted the cleanup/rename-remove-invisible-nodes branch September 17, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HtmlPruner::removeInvisibleNodes could/should be better named?
2 participants