Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Make the $css parameter of the inlineCss method optional #700

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[TASK] Make the $css parameter of the inlineCss method optional #700

merged 1 commit into from
Sep 11, 2019

Conversation

oliverklee
Copy link
Contributor

Fixes #696

@oliverklee oliverklee added this to the 3.0.0 milestone Sep 11, 2019
@oliverklee oliverklee self-assigned this Sep 11, 2019
JakeQZ
JakeQZ approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also aware of several instances in CssInlinerTest that would benefit from this change. With these updated, I don't think we need any additional test 😎

@JakeQZ JakeQZ merged commit d2dc263 into master Sep 11, 2019
@JakeQZ JakeQZ deleted the task/optional-css branch September 11, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Make the argument for CssInliner::inlineCss optional
2 participants
@oliverklee @JakeQZ