Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CSS selectors with semicolons #550

Closed
oliverklee opened this issue Apr 3, 2018 · 5 comments · Fixed by #704
Closed

Allow CSS selectors with semicolons #550

oliverklee opened this issue Apr 3, 2018 · 5 comments · Fixed by #704
Assignees
@JakeQZ
Labels
bug unit tests needed
Milestone
3.0.0

Comments

@oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added the bug label Apr 3, 2018
@oliverklee oliverklee added this to the 3.0.0 milestone Apr 3, 2018
@JakeQZ JakeQZ self-assigned this Sep 11, 2019
@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 11, 2019

@oliverklee, I assume this is closely relates to #333 and refers to semicolons in attribute selectors - but let me know if it was something else.

@oliverklee
Copy link
Contributor Author

Yes, that's correct.

@oliverklee
Copy link
Contributor Author

I started some work in the bugfix/colon and bugfix/semicolon branches, but never finished it. The branches could be a starting point, though.

@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 11, 2019

I started some work in the bugfix/colon and bugfix/semicolon branches, but never finished it. The branches could be a starting point, though.

I found those branches. But now we are using the Symfony CssSelector component, resolving these issues should just be a case of adding unit tests to confirm they are fixed with it, and I'm thinking that we don't need particularly extensive unit tests, as Symfony should have its own - just enough so that we can list fixes in the CHANGELOG...?

@oliverklee
Copy link
Contributor Author

I agree.

JakeQZ added a commit that referenced this issue Sep 11, 2019
@JakeQZ
[TASK] Test special characters in attribute selectors
8a65609 
These have been fixed by virtue of using the Symfony CssSelector component.  The
additional unit tests confirm this.

Also added a few related, previously-intended unit tests which had a placeholder
comment “broken: …”.

Closes #284, closes #333, and closes #550.
@JakeQZ JakeQZ mentioned this issue Sep 11, 2019
Merged
oliverklee pushed a commit that referenced this issue Sep 12, 2019
@JakeQZ @oliverklee
[TASK] Test special characters in attribute selectors (#704)
c8df4de 
These have been fixed by virtue of using the Symfony CssSelector component.  The
additional unit tests confirm this.

Also added a few related, previously-intended unit tests which had a placeholder
comment “broken: …”.

Closes #284
Closes #333
Closes #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeQZ JakeQZ

Labels
bug unit tests needed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[TASK] Test special characters in attribute selectors MyIntervals/emogrifier
2 participants
@oliverklee @JakeQZ