Mobile super btn #32
Closed
Mobile super btn #32
+202
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsurf22 we decided to make this into a pr because theres some additional changes we need for documentation |
gesseekur
commented
Sep 16, 2020
| /** | ||
| * standard, large-right-image | ||
| */ | ||
| btnMode: { |
There was a problem hiding this comment.
can you add these new props to storybook so we can test it!
| :class="getRowClasses()" | ||
| <div class="global--mew-component--mew-super-button"> | ||
| <div | ||
| v-if="btnMode === 'large-right-image'" |
There was a problem hiding this comment.
its better to compare this to an object or array rather than the string,
so below:
this.btnModes = ['large-right-image', 'standard']
and then v-if="btnMode === "btnModes[0]"
| <div | ||
| v-if="btnMode === 'large-right-image'" | ||
| class="btn--b large-right-image" | ||
| :class="[colorTheme === 'basic' ? 'white titlePrimary--text' : '']" |
There was a problem hiding this comment.
same here, I have examples in my code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.