Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mew-address-select showing wrong identicon bug #296

Merged
merged 2 commits into from
Sep 6, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: mew-address-select showing identicon bug
hsurf22 committed Aug 24, 2022
commit 420de9e87c9cf3245af86bc86ed8683d1ff232ba
15 changes: 6 additions & 9 deletions src/components/MewAddressSelect/MewAddressSelect.vue
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
:disabled="disabled"
:error-messages="errorMessages"
:hint="hint || resolvedAddr || ''"
:persistent-hint="hint.length > 0 || resolvedAddr.length > 0"
:persistent-hint="resolvedAddr.length > 0"
:rules="rules"
:no-data-text="noDataText"
:menu-props="{ value: dropdown, closeOnClick: true }"
@@ -144,7 +144,7 @@ export default {
},
props: {
/**
* Text displayed under the input container.
* Text displayed under the input container.
*/
hint: {
type: String,
@@ -272,20 +272,17 @@ export default {
* the blockie for the regular address value.
*/
blockieHash() {
return this.addressValue.address || this.addressValue;
/*
return this.resolvedAddr.length > 0
? this.resolvedAddr
: this.addressValue.address
? this.addressValue.address
: this.addressValue;
*/
}
},
methods: {
/**
* Clears the v-model value.
*/
clear() {
this.addressValue = '';
},
/**
* Emits 'saveAddress' when triggered by save address button.
*/
@@ -370,4 +367,4 @@ export default {
}
}
}
</style>
</style>