fix: update mew-notification by using v-expansion-panels #254
+305
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsurf22
requested review from
Abyscuit,
andrewdahn,
gamalielhere,
jmjles and
NewCodeOnDaBlock
iluvboba
reviewed
May 24, 2022
| " | ||
| :class="[ | ||
| getClasses(notification.status.value.toLowerCase()), | ||
| 'indicator', |
There was a problem hiding this comment.
the indicator styles isn't showing up anymore from the indicator class
There was a problem hiding this comment.
fixed by adjusting content width
There was a problem hiding this comment.
oh i meant its not getting the styles from the .indicator class for some reason
There was a problem hiding this comment.
so its a square instead of a circle
There was a problem hiding this comment.
fixed the indicator shape
iluvboba
reviewed
May 24, 2022
| <!-- ===================================================================================== --> | ||
| <!-- Mew Notifications --> | ||
| <!-- ===================================================================================== --> | ||
| <div |
There was a problem hiding this comment.
unused code removed
|
also clicking on the notification should remove the outside border at least that is how it is currently working |
remove unused codes
|
also clicking on the notification should remove the outside border at least that is how it is currently working 2022-05-26.19-16-43.mp4 |
iluvboba
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update mew-notification by using v-expansion-panels
https://app.asana.com/0/1125971615701970/1202297334683712