Checkbox update #22
Merged
Checkbox update #22
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamalielhere
force-pushed
the
checkbox-update
branch
from
ea1aacd to
056a506
Compare
gesseekur
reviewed
Sep 14, 2020
| @@ -35,11 +29,20 @@ export default { | |||
| default: function() { | |||
| return { title: '', url: ''}; | |||
| } | |||
| }, | |||
| value: { | |||
There was a problem hiding this comment.
hmm is this suppose to match the prop name isChecked ?
There was a problem hiding this comment.
oohh i think i get it now
There was a problem hiding this comment.
yeah no. so v-model is the same as passing :value="something" @value="something" ie:
<mew-checkbox v-model="something"></mew-checkbox>
<mew-checkbox :value="something" @input="something = $event"></mew-checkbox>
So it should work the same but when the value changes, the parent can react to it aswell. Only thing is that there's no data object in storybook so I cant use it there at the moment since I cant mutate props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.