bar #1

Mouvedia · 2024-03-02T14:52:00Z

No description provided.

- https://rust-cli.github.io/book/index.html - https://github.com/clap-rs/clap/blob/7126f78421de4041c0de2f0c4a2141fa50f8b54a/examples/tutorial_derive/03_04_subcommands_alt.rs

https://github.com/mara214/rsnake

wip

…irst line

…es are silent parse errors

todo: refaxctor how width/height is passed

Mouvedia

J'ai review 40%.
Il me reste src et static.

CONTRIBUTING.md

Cargo.toml

Mouvedia · 2024-03-02T15:14:45Z

src/render_browser/broadcast.rs

+
+        // try to send to all clients, ignoring failures
+        // disconnected clients will get swept up by `remove_stale_clients`
+        let _ = future::join_all(send_futures).await;


read

rust-lang/rust#91642

.gitignore

CONTRIBUTING.md

node-helpers/dev-server-sse/server.ts

node-helpers/package.json

Mouvedia#1

Mouvedia

30 fichiers sur 50

Mouvedia · 2024-03-03T10:14:16Z

node-helpers/tsconfig.json

+    // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
+    // "moduleDetection": "auto",                        /* Control what method is used to detect module-format JS files. */
+    /* Modules */
+    "module": "NodeNext", /* Specify what module code is generated. */


minor

node16 implies --target es2022

Basé sur le .nvmrc et la l12 jte conseillerais de changer pour node16 car ce serait plus en phase avec les recommandations de Microsoft.

Mouvedia · 2024-03-03T10:17:15Z

package.json

+  "name": "snake-pipe-rust",
+  "version": "0.1.0",
+  "private": true,
+  "description": "You only need this part for better experience with js development, not mandadtory.",


typos

a better ou an easier

mandatory

Sur cette branche

https://github.com/topheman/snake-pipe-rust/blob/7ed882a4243e31e6794e9146e6292a18a0507a3b/package.json#L5

tu as encore "mandadtory".

Mouvedia · 2024-03-03T10:39:07Z

src/common.rs

+pub fn format_version_with_features(
+    versions_with_features: IndexMap<String, Vec<String>>,
+) -> String {
+    if versions_with_features.len() == 1 {


question

C'est étrange ça, tu gères le else comme si c'était > 1 mais on peut t'en passer un vide, non?

C'est bien == 1. Au cas où il n'y a qu'une seule version, inutile de spécifier les features.

Je veux dire que le code après ce if que je considère comme un else—à cause du return—est géré comme > 1 alors que potentiellement tu pourrais avoir 0.

src/common.rs

Mouvedia · 2024-03-03T12:05:42Z

src/input.rs

+    pub snake_length: u32,
+    pub size: SizeOption,
+    pub features_with_version: std::collections::HashMap<String, String>,
+    pub metadatas: std::collections::HashMap<String, String>,


typo

c'est "uncountable"
metadata

Si tu veux remplacer metadatas par uncountable, il peut y avoir beaucoup de choses dedans.

Si tu veux remplacer metadatas par uncountable

Non je veux dire que le pluriel et le singulier de metadata sont les mêmes.
i.e. metadata ne prend pas de s au pluriel

Mouvedia · 2024-03-03T12:08:53Z

src/main.rs

+            let _ = crossterm::terminal::enable_raw_mode();
+            let _ = gamestate_run(game_options); // this function returns when ctrl+c is hit
+            let _ = crossterm::terminal::disable_raw_mode();
+            std::process::exit(130); // todo handle other signals ?


minor

magic number
const

src/main.rs

Mouvedia · 2024-03-03T12:18:34Z

src/pipeline.rs

+        None => {
+            if list {
+                println!("{}", "List of pipelines:".bold().underline());
+                generate_command(Some(Pipeline::Play), false, "play");


question

ya un moyen meta de référencer les cases utilisés dans le match ?
ça te permettrait de loop et de pas à avoir à maintenir ce if

Mouvedia#1

Will be in #35

Mouvedia

54/54

Mouvedia · 2024-03-09T09:21:14Z

src/render.rs

+            queue!(
+                stdout,
+                cursor::RestorePosition,
+                terminal::Clear(terminal::ClearType::FromCursorDown),
+                cursor::Show,
+            )
+            .unwrap();


refactor
minor

ça pourrait ptet être une fonction
voir l57

Mouvedia · 2024-03-09T09:22:18Z

src/render.rs

+                    cursor::Show,
+                )
+                .unwrap();
+                std::process::exit(130);


minor

voir https://github.com/Mouvedia/snake-pipe-rust/pull/1/files#r1510251029

Mouvedia · 2024-03-09T09:36:05Z

src/render.rs

+/**
+ * `<https://en.wikipedia.org/wiki/Box-drawing_character>`
+ */
+fn render_line_wrapper(width: u32, top: bool) -> String {


minor

Le bool arg me semble être un code smell.

Il serait plus clair d'avoir un let line_corners = et un seul format

Tu peux élaborer ?

pour 1. ça vient de clean code—le bouquin—c'est un mauvais signe lorsque un bool arg est utilisé par une fonction ayant plusieurs arguments
e.g. pour un toggler c'est bon

pour 2. le match bool me semble over the top, en gros 2 couples de strings nommées top et bottom permettrait d'avoir qu'un seul call de format

src/render.rs

src/render_browser/broadcast.rs

static/main.js

Mouvedia · 2024-03-09T10:48:05Z

static/renderers/basic.js

@@ -0,0 +1,90 @@
+import { makeRenderInfos } from './utils.js'
+
+const renderInfos = makeRenderInfos(["score", "version"]);


minor

pareil que #1 (comment)
info singulier et pluriel

static/renderers/basic.js

static/types.d.ts

…t_cross_compile_demo/blob/master/.github/workflows/build.yaml

topheman added 30 commits February 2, 2024 14:32

feat(*): add empty common::stream

2782ae1

feat(cli): begin cli implementation with clap

b333877

- https://rust-cli.github.io/book/index.html - https://github.com/clap-rs/clap/blob/7126f78421de4041c0de2f0c4a2141fa50f8b54a/examples/tutorial_derive/03_04_subcommands_alt.rs

feat(snake): snake implementation from rsnake

3cb5a20

https://github.com/mara214/rsnake

feat(terminal): basic terminal key binding

6034a22

feat(terminal): basic serialization without event loop

6bef31b

wip

feat(*): serialize gamestate to json with serde

7b6f5bd

feat(*): accept initOptions from cli and serialize them on the very f…

81b7068

…irst line

feat(*): take --frame-duration in account

49f932e

feat(*): take --width and --height in account

1ccfdad

feat(*): read stdin from render command

9a7efbc

feat(*): stream::parse_gamestate()

7b716a1

feat(*): handle errors in stream::parse_gamestate()

41da97a

fix(*): missing public fields

2fa21bc

chore(*): ignore render.out - temp working file

a46a91e

feat(*): Raise error message - only for first parsed line - other lin…

0ac898c

…es are silent parse errors

feat(*): setup throttle

573226a

feat(*): serialize throttle's output

7154818

feat(*): basic render

e78665a

feat(*): render_frame

9518ba4

feat(*): better handle render in terminal

575cb14

feat(*): correct handling of cursor position

d8b3cf5

feat(*): show cursor back on ctrl+c

4b5e905

feat(*): dont leave rendered on ctrlc

5a0db66

feat(*): draw level limits

5325da4

feat(*): default value of frame_duration at 120ms

de483f1

feat(*): stop print when GameState is Over/Paused + use enum GameState

ed2af65

feat(*): display score

287313f

feat(*): fix passing different width / height

ba1ced4

todo: refaxctor how width/height is passed

refactor(*): remove unused import

ce2bb05

feat(*): fix direction in gamestate

ed90e21

topheman added 2 commits March 2, 2024 12:07

docs(#38): update CONTRIBUTING.md

2e68d21

feat(#38): feedback PR

d060e43

Mouvedia commented Mar 2, 2024

View reviewed changes

topheman added a commit to topheman/snake-pipe-rust that referenced this pull request Mar 2, 2024

refactor(*): feedback review from @Mouvedia

2bc4d55

Mouvedia#1

topheman mentioned this pull request Mar 2, 2024

refactor(*): feedback review from @Mouvedia topheman/snake-pipe-rust#43

Merged

topheman added a commit to topheman/snake-pipe-rust that referenced this pull request Mar 3, 2024

refactor(*): feedback review from @Mouvedia

a60ce55

Mouvedia#1

topheman added 2 commits March 3, 2024 13:01

feat(#36): add a zoom slider

b08319a

feat(#36): better style for the qrcode part

fa1f797

Mouvedia commented Mar 3, 2024

View reviewed changes

topheman added a commit to topheman/snake-pipe-rust that referenced this pull request Mar 3, 2024

refactor(*): feedback review from @Mouvedia

a0b5898

Mouvedia#1

topheman added 2 commits March 3, 2024 16:34

feat(#46): check if port is available before launching render-browser

f5b514f

feat(#18): generate QrCode from location.origin or renderBrowerHost

86726e9

topheman added a commit to topheman/snake-pipe-rust that referenced this pull request Mar 6, 2024

refactor(*): feedback review from @Mouvedia

8a1c0cd

Mouvedia#1

topheman added 6 commits March 6, 2024 19:25

refactor(*): feedback review from @Mouvedia

c4a7b81

Mouvedia#1

fix(*): correct docs - unix socket are not yet supported

4c2bb58

Will be in #35

docs(*): update contributing section of README.md

9004d35

chore(#50): prepare MacOS intel/arm compilation

db78e00

docs: remove mention of next version

ccb5537

bump to v2.0.0

7ed882a

Mouvedia commented Mar 9, 2024

View reviewed changes

topheman added 9 commits March 10, 2024 17:59

refactor: feedback review 2 from @Mouvedia

9c9c8a7

chore(#50): create workflow inspired of https://github.com/Timmmm/rus…

fbfe821

…t_cross_compile_demo/blob/master/.github/workflows/build.yaml

chore(#50): adapt workflow

73fa0c6

chore(#50): compress artefacts in .tar.gz and upload them

1a47689

chore(#50): add target x86_64-unknown-linux-gnu on github actions

b807d5f

refactor(#50): rename cross-compile-macos.yml into cross-compile.yml

58b0714

feat(#50): calculate sha256

7164f45

docs(#50): update PUBLISHING.md

d939f2b

docs(#50): update README.md

8141986

Mouvedia closed this Mar 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bar #1

bar #1

Mouvedia commented Mar 2, 2024

Mouvedia left a comment

Mouvedia Mar 2, 2024

Mouvedia left a comment

Mouvedia Mar 3, 2024

Mouvedia Mar 3, 2024 •

edited

Loading

topheman Mar 9, 2024

Mouvedia Mar 9, 2024

Mouvedia Mar 3, 2024

topheman Mar 3, 2024

Mouvedia Mar 3, 2024

Mouvedia Mar 3, 2024

topheman Mar 3, 2024

Mouvedia Mar 3, 2024

Mouvedia Mar 3, 2024

Mouvedia Mar 3, 2024

Mouvedia left a comment

Mouvedia Mar 9, 2024

Mouvedia Mar 9, 2024

Mouvedia Mar 9, 2024

topheman Mar 9, 2024

Mouvedia Mar 9, 2024 •

edited

Loading

Mouvedia Mar 9, 2024

		@@ -0,0 +1,90 @@
		import { makeRenderInfos } from './utils.js'

		const renderInfos = makeRenderInfos(["score", "version"]);

bar #1

bar #1

Conversation

Mouvedia commented Mar 2, 2024

Mouvedia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mouvedia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mouvedia Mar 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mouvedia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mouvedia Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mouvedia Mar 3, 2024 •

edited

Loading

Mouvedia Mar 9, 2024 •

edited

Loading