-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make config keys configurable with components #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very C# like with how everything has interfaces and abstractions, which IG is what Banane wants... At least IMO should stick to consistent interface/class definition file split (&order) tho, can't say I see much wrong with the implementation.... because I don't feel like I have enough free time to dedicate to trying to figure out how this'll be used from a modder's perspective...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the defining a config perspective: DefiningConfigKey<int> testKey = new("Test", ...)
{
new ConfigKeyRange(0, 255)
} The constructor still has the standard things too, but now more behavior can be added super easily. E.g. Quantities or Shared for Resonite. |
…nts to make ML.Components using unnecessary.
This is an implementation of config key components as mentioned in #9. Feedback is appreciated.
Resolves #9.
To Do: