-
Notifications
You must be signed in to change notification settings - Fork 1k
Update nf-wingdi-createfontw.md #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs
Are you sure you want to change the base?
Conversation
@DJm00n : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Thanks, @DJm00n, I like the idea in general of changing HTML to markdown! But why are we making this particular change? Note that we're losing value by removing headings such as "Korean Windows". Is the expectation that readers will already know that JOHAB_CHARSET == Korean? Or if not, they can go look it up? Seems dubious. In any case, for a constant such as JOHAB_CHARSET, I'd put that in bold (asterisk asterisk), and not backticks. Backticks are for code, filenames, that kind of thing. Also, parameter names should be in italics (as they were before this change), not backticks (as they are after this change). But again changing HTML to markdown italics is desirable. So I won't take this PR right now. Thanks! :) |
Format legacy
*_CHARSET
constant tables.