Rework using IPC event #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3SOX
commented
Jan 27, 2024
•
D3SOX
commented
- A lot of refactoring
- Don't use hard-coded Discord class for icon style
- Use existing method to format the duration
- Added a setting whether to track it for yourself or not (Maybe we could depend on the state of the CallTimer plugin here)
- Now using IPC events and a simple map to store the join times
|
Oops, changing the guild resets the timers because the component is remounted. Need to fix |
component gets remounted so the timer needs to use a fixed start time
I didn't think about this at the time lol
|
Thanks for these changes they are fantastic! One issue which I will fix in the main pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.