Support for closing on click and edge slide in options.

[lewie9021]

It's common in mobile apps for the menu to only slide in when dragged from the edge of the screen (not the whole screen). The new grabWidth option will allow configuring what threshold this is. If not specified, the behaviour will revert back to how it currently is. I have also added an option to allow closing the menu when it's opened (closeOnClick) by simply clicking the panel element.

[pazguille]

Hmm, not sure about grabWidth option. What do others think?

I really like closeOnClick option but you can do it from outside. I would like to keep slideout.js as tiny as possible.

document.querySelector('.slideout-panel').addEventListener('click', function(eve) {
  if (slideout.isOpen()) {
    eve.preventDefault();
    slideout.close();
  }
});

[lewie9021]

I do agree about closeOnClick as it's rather simple to implement the feature if they wish so.

As for grabWidth, I feel it's necessary since the menu will slide out with any horizontal scrolling in the panel content. It's also common behaviour with most off canvas menus (or at least the ones I have used) for the menu to only slide out when swiped from the edge.

[ZinedinShiqin]

{Arch Rom} (Phonetics) , for this phone and the line between.thanks

[garygreen]

@pazguille I'm actually the other way around, I dislike the closeOnClick that seems pretty subjective, I personally don't like the idea of panel closing on click but the grabWidth really does need to be implemented. It seems so strange to have the whole page listen to when the slider should open... there should be an option to confine to the side of the screen, which is pretty much the standard in most mobile apps and the adopted standard in Android.

+1 to this PR though, it fixes a lot of issues when you have sliding carousels in your page etc. Also helps prevents the menu starting to open sometimes when your scrolling.

[garygreen]

@pazguille any news on if this PR will be accepted or left open forever? ;D

[nicmare]

vote!

[garygreen]

@pazguille PLEASE can you look at this and make a decision? I find it so frustrating (and my users) that the menu can be triggered from anywhere on the page. There should be an option to confine it to only open within X amount of pixels from the screen, which this PR does perfectly.

[mauron85]

+1

[jonathandey]

+1