Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker enhancements #3696

Merged
merged 5 commits into from
Nov 19, 2019
Merged

DatePicker enhancements #3696

merged 5 commits into from
Nov 19, 2019

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Nov 18, 2019 •
edited
Loading

Describe the changes you have made to improve this project

  • Add DatePickerHelper with new attached properties. This allows us to handle this button separately to another clear button.
    • DropDownButtonContent
    • DropDownButtonContentTemplate
    • DropDownButtonFontFamily
    • DropDownButtonFontSize
  • Use new DatePicker helper for DateTimePicker and TimePicker
  • Introduce MahAppsCommands.ClearControlCommand
    • This command does the same as the attached TextBoxHelper IsClearTextButtonBehaviorEnabled property and should be used later for all controls too. So then we doesn't need 2 separate styles for ButtonCommand usage.
  • Implement clear button for DatePicker
  • Implement clear button for DateTimePicker and TimePicker

image

Unit test

-/-

Closed Issues

Closes #3656

@punker76 punker76 added this to the 2.0.0 milestone Nov 18, 2019
@punker76 punker76 force-pushed the DatePicker_Enhancement branch from 186f015 to 86c56d0 Compare November 18, 2019 10:05
@timunie
Copy link
Collaborator

timunie commented Nov 18, 2019

Hi @punker76 ,
Thinking further I think this Helper class could be used for ComboBox DropDownButton etc in the future. So maybe we should call it more general like DropDownHelper.

Happy coding
Tim

@punker76
(GH-3656) Add DatePickerHelper
7c8f5c1 
Add DatePickerHelper with new attached properties

- `DropDownButtonContent`
- `DropDownButtonContentTemplate`
- `DropDownButtonFontFamily`
- `DropDownButtonFontSize`

This allows us to handle this button separately to another clear button. 

(GH-3656) Make helper class static
@punker76
(GH-3656) Use new DatePicker helper for DateTimePicker and TimePicker
9576cdf
@punker76 punker76 force-pushed the DatePicker_Enhancement branch from 21fbc1b to 9576cdf Compare November 18, 2019 22:11
@punker76
(GH-3656) Introduce MahAppsCommands.ClearControlCommand
37f8f9a 
This command does the same as the attached TextBoxHelper IsClearTextButtonBehaviorEnabled property and should be used later for all controls too. So then we doesn't need 2 separate styles for ButtonCommand.
@punker76
(GH-3656) Implement clear button for DatePicker
230556c
@punker76
(GH-3656) Implement clear button for DateTimePicker and TimePicker
afd4462
@punker76 punker76 changed the title WIP DatePicker enhancements DatePicker enhancements Nov 19, 2019
@punker76 punker76 merged commit 62aa81d into develop Nov 19, 2019
@punker76 punker76 deleted the DatePicker_Enhancement branch November 19, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Clear Button in DatePicker
2 participants
@punker76 @timunie