Add the ability to control button font size in dialogs via MetroDialogSettings #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeikTranel
commented
Oct 3, 2019
| @@ -103,12 +103,13 @@ public double DialogMessageFontSize | |||
| } | |||
|
|
|||
| /// <summary>Identifies the <see cref="DialogButtonFontSize"/> dependency property.</summary> | |||
| public static readonly DependencyProperty DialogButtonFontSizeProperty = DependencyProperty.Register(nameof(DialogButtonFontSize), typeof(double), typeof(BaseMetroDialog), new PropertyMetadata(12D)); | |||
| public static readonly DependencyProperty DialogButtonFontSizeProperty = DependencyProperty.Register(nameof(DialogButtonFontSize), typeof(double), typeof(BaseMetroDialog), new PropertyMetadata(SystemFonts.MessageFontSize)); | |||
There was a problem hiding this comment.
Heh. Didn't know this existed :D
There was a problem hiding this comment.
NP, I copied it from the default of the Button control.
MeikTranel
commented
Oct 3, 2019
|
|
||
| /// <summary> | ||
| /// Gets or sets the font size of any dialog buttons. | ||
| /// </summary> | ||
| public double DialogButtonFontSize { | ||
| public double DialogButtonFontSize | ||
| { |
There was a problem hiding this comment.
Maybe it's worth checking in some editorconfigs and StyleCop configs. This kind of work must be adding up with this much traffic on this repo 😄
There was a problem hiding this comment.
Yeah, I should add it to the existing editorconfig.
|
@MeikTranel your #Hacktoberfest changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
Added the DialogButtonFontSize Property to MetroDialogSettings and integrated them in sync with the existing implementations of DialogTitleFontSize and DialogMessageFontSize.
Additional Context
In a second commit (without issue reference) i also added an entry to the demo app sampling the usage of the new property. I didn't know whether this is appreciated or not.
Defaulting to 12pt:
Using override 30pt:
Closed Issues
Closes #3618