Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete Styles and Templates #3395

Merged
merged 16 commits into from
Dec 11, 2018
Merged

Remove obsolete Styles and Templates #3395

merged 16 commits into from
Dec 11, 2018

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Dec 10, 2018 •
edited
Loading

Describe the changes you have made to improve this project

This PR removes all unnecessary / obsolete styles and templates.

obsolete new
CleanWindowButtonStyle
CleanCloseWindowButtonStyle
MetroWindowButtonStyle
MetroBaseWindowButtonStyle		 LightCleanWindowCloseButtonStyle
DarkCleanWindowCloseButtonStyle
VerticalScrollViewerTemplate (ControlTemplate) ScrollViewerTemplate (ControlTemplate)
ComboBoxPopupBrush
MenuItemDisabledBrush		 ComboBoxPopupBorderBrush
GrayBrush3
MahApps.Metro.Styles.MetroCircleFocusVisual
MetroCircleButtonFocusVisual
MetroCircleButtonStyle
MetroCircleToggleButtonStyle
MetroButton
MetroToggleButton		 MahApps.Metro.Styles.CircleButtonFocusVisualStyle
MahApps.Metro.Styles.MetroCircleButtonStyle
MahApps.Metro.Styles.MetroCircleToggleButtonStyle
MahApps.Metro.Styles.MetroButton
MahApps.Metro.Styles.MetroToggleButton
HorizontalSliderThumb
HorizontalTrackLargeDecrease
HorizontalTrackValue
HorizontalSliderTemplate
VerticalSliderThumb
VerticalTrackLargeDecrease
VerticalTrackValue
VerticalSliderTemplate
MetroSlider
SliderButtonStyle (FlatSlider)
SliderThumbStyle (FlatSlider)
SliderTickBarStyle (FlatSlider)
HorizontalSlider (FlatSlider)
VerticalSlider (FlatSlider)
FlatSlider		 MahApps.Metro.Styles.Slider.Thumb
MahApps.Metro.Styles.Slider.HorizontalTrack
MahApps.Metro.Styles.Slider.HorizontalTrackValue
MahApps.Metro.Styles.Slider.HorizontalTemplate
MahApps.Metro.Styles.Slider.VerticalTrack
MahApps.Metro.Styles.Slider.VerticalTrackValue
MahApps.Metro.Styles.Slider.VerticalTemplate
MahApps.Metro.Styles.Slider
MahApps.Metro.Styles.FlatSlider.Track (FlatSlider)
MahApps.Metro.Styles.FlatSlider.Thumb (FlatSlider)
MahApps.Metro.Styles.FlatSlider.TickBar (FlatSlider)
MahApps.Metro.Styles.FlatSlider.HorizontalTemplate (FlatSlider)
MahApps.Metro.Styles.FlatSlider.VerticalTemplate (FlatSlider)
MahApps.Metro.Styles.FlatSlider
MetroCalendarDayButtonStyle
MetroCalendarItemStyle
MetroCalendarButtonStyle
MetroCalendar		 MahApps.Metro.Styles.MetroCalendarDayButtonStyle
MahApps.Metro.Styles.MetroCalendarItemStyle
MahApps.Metro.Styles.MetroCalendarButtonStyle
MahApps.Metro.Styles.MetroCalendar
StringToOppositeVisibilityConverter
RevealButtonIcon		 DefaultRevealButtonIcon
MetroToggleSwitchButton
MetroToggleSwitch		 MahApps.Metro.Styles.ToggleSwitchButton
MahApps.Metro.Styles.ToggleSwitch
MetroProgressBar MahApps.Metro.Styles.ProgressBar
ButtonCommandMetroTextBox MetroButtonTextBox
TreeViewItemFocusVisual -/-
SplitButtonHorizontal
SplitButtonVertical		 -/-
ExpoEaseIn
ExpoEaseOut		 ExpoEaseInOut (ShowFloatingMessageStoryboard, HideFloatingMessageStoryboard)
HamburgerListBoxStyle
HamburgerListBoxItemStyle		 HamburgerMenuListStyle
HamburgerMenuItemStyle

Unit test

-/-

Additional context

-/-

Closed Issues

Closes #3396

@punker76
obsolete:
9299e96 
	CleanWindowButtonStyle
	CleanCloseWindowButtonStyle
	MetroWindowButtonStyle
	MetroBaseWindowButtonStyle
new:
	LightCleanWindowCloseButtonStyle
	DarkCleanWindowCloseButtonStyle
@punker76 punker76 added this to the 2.0.0 milestone Dec 10, 2018
@punker76 punker76 changed the title WIP Remove obsolete Styles WIP Remove obsolete Styles and Templates Dec 10, 2018
@punker76
obsolete:
9084ecc 
	VerticalScrollViewerTemplate (ControlTemplate)
new:
	ScrollViewerTemplate (ControlTemplate)
@punker76
obsolete:
919d07c 
	HamburgerListBoxStyle
	HamburgerListBoxItemStyle
new:
	HamburgerMenuListStyle
	HamburgerMenuItemStyle
@punker76
obsolete:
18ccf41 
	ExpoEaseIn
	ExpoEaseOut
new:
	ExpoEaseInOut (ShowFloatingMessageStoryboard, HideFloatingMessageStoryboard)
@punker76
obsolete:
4faaf99 
	SplitButtonHorizontal
	SplitButtonVertical
new:
	-/-
@punker76
obsolete:
bcdbf7b 
	TreeViewItemFocusVisual
new:
	-/-
@punker76
obsolete:
22531e9 
	ButtonCommandMetroTextBox
new:
	MetroButtonTextBox
@punker76
obsolete:
17e39ae 
	MetroProgressBar
new:
	MahApps.Metro.Styles.ProgressBar
@punker76
obsolete:
4ab131b 
	MetroToggleSwitchButton
	MetroToggleSwitch
new:
	MahApps.Metro.Styles.ToggleSwitchButton
	MahApps.Metro.Styles.ToggleSwitch
@punker76
obsolete:
3067371 
	StringToOppositeVisibilityConverter
	RevealButtonIcon
new:
	DefaultRevealButtonIcon
@punker76
obsolete:
9aed66f 
	MetroCalendarDayButtonStyle
	MetroCalendarItemStyle
	MetroCalendarButtonStyle
	MetroCalendar
new:
	MahApps.Metro.Styles.MetroCalendarDayButtonStyle
	MahApps.Metro.Styles.MetroCalendarItemStyle
	MahApps.Metro.Styles.MetroCalendarButtonStyle
	MahApps.Metro.Styles.MetroCalendar
@punker76
obsolete:
2284216 
	HorizontalSliderThumb
	HorizontalTrackLargeDecrease
	HorizontalTrackValue
	HorizontalSliderTemplate
	VerticalSliderThumb
	VerticalTrackLargeDecrease
	VerticalTrackValue
	VerticalSliderTemplate
	MetroSlider
	SliderButtonStyle (FlatSlider)
	SliderThumbStyle (FlatSlider)
	SliderTickBarStyle (FlatSlider)
	HorizontalSlider (FlatSlider)
	VerticalSlider (FlatSlider)
	FlatSlider
new:
	MahApps.Metro.Styles.Slider.Thumb
	MahApps.Metro.Styles.Slider.HorizontalTrack
	MahApps.Metro.Styles.Slider.HorizontalTrackValue
	MahApps.Metro.Styles.Slider.HorizontalTemplate
	MahApps.Metro.Styles.Slider.VerticalTrack
	MahApps.Metro.Styles.Slider.VerticalTrackValue
	MahApps.Metro.Styles.Slider.VerticalTemplate
	MahApps.Metro.Styles.Slider
	MahApps.Metro.Styles.FlatSlider.Track (FlatSlider)
	MahApps.Metro.Styles.FlatSlider.Thumb (FlatSlider)
	MahApps.Metro.Styles.FlatSlider.TickBar (FlatSlider)
	MahApps.Metro.Styles.FlatSlider.HorizontalTemplate (FlatSlider)
	MahApps.Metro.Styles.FlatSlider.VerticalTemplate (FlatSlider)
	MahApps.Metro.Styles.FlatSlider
@punker76
obsolete:
3f8ecad 
	MahApps.Metro.Styles.MetroCircleFocusVisual
	MetroCircleButtonFocusVisual
	MetroCircleButtonStyle
	MetroCircleToggleButtonStyle
	MetroButton
	MetroToggleButton
new:
	MahApps.Metro.Styles.CircleButtonFocusVisualStyle
	MahApps.Metro.Styles.MetroCircleButtonStyle
	MahApps.Metro.Styles.MetroCircleToggleButtonStyle
	MahApps.Metro.Styles.MetroButton
	MahApps.Metro.Styles.MetroToggleButton
@punker76
remove old Colors.xaml
9d87e7a 
Relates to #3296
@punker76
obsolete:
bc9f2d3 
	ComboBoxPopupBrush
	MenuItemDisabledBrush
new:
	ComboBoxPopupBorderBrush
	GrayBrush3
@punker76 punker76 changed the title WIP Remove obsolete Styles and Templates Remove obsolete Styles and Templates Dec 11, 2018
@Nuklon
Copy link
Contributor

Nuklon commented Dec 11, 2018

Will this also remove the old non-Win10 styles? As there are some components with Win10 styles (that look much better).

@punker76
Copy link
Member Author

@Nuklon Not yet, the Win10 styles will be the default one, but in another PR (issues already exists).

@punker76 punker76 merged commit 5200e9e into develop Dec 11, 2018
@punker76 punker76 deleted the feature/Remove_obsolete_Styles branch December 11, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@punker76 @Nuklon