WIP Handle CloseButton together with ShowDialogsOverTitleBar #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New `CanCloseDialogOwner` property at `MetroDialogSettings` which can be used to handle how the owner of the dialog can be closed. - New `IsCloseButtonEnabledWithDialog` property at `MetroWindow` which indicates if the close button should be enabled or not if a dialog is shown.
- Add trigger for `IsCloseButtonEnabledWithDialog` at WindowButtonCommands for PART_Close button - `HandleOverlayOnHide` sets the `IsCloseButtonEnabledWithDialogPropertyKey` and restores focus if needed - `HandleOverlayOnShow` sets the `IsCloseButtonEnabledWithDialogPropertyKey`
punker76
deleted the
feature/GH-2882_ShowDialogsOverTitleBar_Window_CloseButton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
OwnerCanCloseWithDialogproperty atMetroDialogSettingswhich can be used to handle how the owner of the dialog can be closed.IsCloseButtonEnabledWithDialogproperty atMetroWindowwhich indicates if the close button should be enabled or not if a dialog is shown.HandleOverlayOnHidesets theIsCloseButtonEnabledWithDialogPropertyKeyand restores focus if neededHandleOverlayOnShowsets theIsCloseButtonEnabledWithDialogPropertyKeyVerified
Closed issues.
Closes #2882