Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In InputDialog,The button is partially invisible. #3408

Closed
li-zheng-hao opened this issue Dec 15, 2018 · 0 comments · Fixed by #3503
Closed

In InputDialog,The button is partially invisible. #3408

li-zheng-hao opened this issue Dec 15, 2018 · 0 comments · Fixed by #3503
Assignees
@punker76
Labels
Bug
Milestone
2.0.0

Comments

@li-zheng-hao
Copy link

My Metro Version is 1.6.5.
bug1
bug2

I tried to resize my window width to smaller than a certain number, this problem happened, but when the window width is big enough, it will not happen.(maybe the container's margin is not suitable?)

I'm a beginner of WPF and Metro, How can I resolve this problem?
@punker76 punker76 added this to the 2.0.0 milestone Dec 19, 2018
@punker76 punker76 self-assigned this Dec 19, 2018
@punker76 punker76 added the Bug label Apr 3, 2019
@punker76 punker76 mentioned this issue May 20, 2019
Closed
punker76 added a commit that referenced this issue May 20, 2019
@punker76
(GH-1936, GH-3408) Improvement for title bar and window commands
779b1ce 
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size.

To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control.

The default window style is now changed to use this new mechanism.

These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command should not overlay when a Flyout is open.

The clean centered style still needs changes for the centered title behavior.
@punker76 punker76 mentioned this issue May 20, 2019
Merged
punker76 added a commit that referenced this issue May 21, 2019
@punker76
(GH-1936, GH-3408) Fix centered title style
2ed1ef9 
The centered window title style works now also with the new window commands overflow mechanism.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fixes and improvements for the new feature
3ea13b8 
- Improve toggle button mouse over and checked visual (change background and foreground)
- Fix binding for Foreground and Background of the inner controls of the WindowCommandsItem
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Improvement for title bar and window commands
b43075e 
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size.

To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control.

The default window style is now changed to use this new mechanism.

These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command should not overlay when a Flyout is open.

The clean centered style still needs changes for the centered title behavior.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fix centered title style
4fdecc3 
The centered window title style works now also with the new window commands overflow mechanism.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fixes and improvements for the new feature
676323b 
- Improve toggle button mouse over and checked visual (change background and foreground)
- Fix binding for Foreground and Background of the inner controls of the WindowCommandsItem
punker76 added a commit that referenced this issue May 24, 2019
@punker76
(GH-1936, GH-3408) Try fix Codacy/PR Quality Review issue
1a234ca 
The 'ParentWindowCommands' must not be a static property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Bug
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Improvement for title bar and window commands MahApps/MahApps.Metro
2 participants
@punker76 @li-zheng-hao