Fixes candidate recommendations collisions #118
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g constant MAX_DISTANCE_ to MIN_DISTANCE_
MarianoGnu
reviewed
Mar 4, 2025
There was a problem hiding this comment.
I have no strong opinions agains or in favor of this PR, buthis does not solve what is reported in the Task.
This is the scenario that is reported:
You cannot click in the candidate that is on top of an atom because it will select the atom instead of creating the candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the minimum distance from a candidate to existing atoms.
The
MAX_DISTANCE_TO_ATOMSwas misleading and was renamed toMIN_DISTANCE_TO_ATOMS