Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds star gears project to the library #117

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

HungryProton
Copy link
Contributor

Star gears is an MSEP project with motors and springs but the library only supports PDB files (atoms & bonds only).

This PR adds the ability to import full MSEP workspaces to the current workspace.

… the star gears sample project to the library
Copy link
Contributor

@MarianoGnu MarianoGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there both star_gears.msep1 and star_gears.msep1.tres files? they are meant to be the same file, and tres is only a temporary file created during loading and save

Copy link
Contributor

@MarianoGnu MarianoGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the load process generates a .tres file in the same location as the .msep1 file we should test how this works after export, because the template file will reside inside of the MSEP.pck file.

The pdb/mol importer creates a copy of the file in a temp folder before actually importing it

# Clear selection in other contexts
var other_contexts: Array[StructureContext] = out_workspace_context.get_structure_contexts_with_selection()
for context: StructureContext in other_contexts:
context.clear_selection()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can replace all this block for
out_workspace_context.clear_all_selection()

@HungryProton
Copy link
Contributor Author

Because the load process generates a .tres file in the same location as the .msep1 file we should test how this works after export, because the template file will reside inside of the MSEP.pck file.

The pdb/mol importer creates a copy of the file in a temp folder before actually importing it

You're right, that doesn't work in exported builds. I'll see if I can move the tres file in another location.

@MarianoGnu MarianoGnu merged commit a948319 into MSEP-one:devel Mar 4, 2025
@MarianoGnu
Copy link
Contributor

Lets address in the next PR, Jonathan is asking to merge stuff

@HungryProton HungryProton deleted the star_gears branch March 24, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants