Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scenes support #24

Merged
merged 4 commits into from
Feb 17, 2024
Merged

feat: Add scenes support #24

merged 4 commits into from
Feb 17, 2024

Conversation

slcp
Copy link
Contributor

@slcp slcp commented Dec 17, 2023

This PR adds support for listing and executing Scenes using the SwitchBot API v1.1.

They have a pretty simple interface with only one operation that takes no data from the consumer. The new functionality is supported by tests. The contributions are intended to be in keeping with the existing style and approach to within this project.

This PR also fixes an existing typo in the repo.

@slcp slcp mentioned this pull request Dec 24, 2023
@LucaDiba
Copy link
Owner

Hi @slcp, thanks for contributing! :)
The PR looks good. I just added a few more tests and refactored some minor things.
I'll merge your changes and publish a new version.

@LucaDiba LucaDiba merged commit 424193a into LucaDiba:main Feb 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants