Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring SlimPajama Preprocessing Code #1838

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

aflah02
Copy link
Contributor

@aflah02 aflah02 commented Nov 27, 2024

Addresses #1837 (comment)

@aflah02 aflah02 changed the title Restored SlimPajama Restoring SlimPajama Preprocessing Code Nov 27, 2024
@aflah02
Copy link
Contributor Author

aflah02 commented Nov 27, 2024

Hi @Andrei-Aksionov
Not sure why the tests are failing as I just copied over a file

@Andrei-Aksionov
Copy link
Contributor

Today was a release of LitServe and apparently it broke something.
Try to pin the version of it in pyproject.toml:

"litserve>=0.2.4",           # litgpt.deploy

It will do for now, later I'll try to fix it and unpin the version.

cc @aniketmaurya

@aflah02
Copy link
Contributor Author

aflah02 commented Nov 27, 2024

Today was a release of LitServe and apparently it broke something. Try to pin the version of it in pyproject.toml:

"litserve>=0.2.4",           # litgpt.deploy

It will do for now, later I'll try to fix it and unpin the version.

cc @aniketmaurya

This still fails. Should I pin it to some other version?

@aniketmaurya
Copy link
Contributor

seems like some other issue with LitGPT? @Andrei-Aksionov

@Andrei-Aksionov
Copy link
Contributor

seems like some other issue with LitGPT?

I doubt it.
This morning it was fine.
And in this PR only one file is added.

I'll investigate it later.

@Andrei-Aksionov Andrei-Aksionov merged commit 3a8ee2a into Lightning-AI:main Nov 28, 2024
3 of 9 checks passed
@Andrei-Aksionov
Copy link
Contributor

Hey @aflah02
The name of your branch (in your fork) tricked by github CLI :)
So I accidentally made changed to our main.
(And had to deal with it.)

Could you create one more PR? 😊
The same content and also with pinned LitServe.

I unpined it today to confirm that the issue with tests was indeed caused by LitServe.
With pinned version all workflows (apart from LitGPT + Thunder) were green.

@aflah02
Copy link
Contributor Author

aflah02 commented Nov 28, 2024

Ah got it
Thanks!
Just to be sure, should I use the pin you suggested or the one @aniketmaurya did?

@Andrei-Aksionov
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants