Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify convexHull #249

Closed
tmcw opened this issue Sep 18, 2013 · 1 comment
Closed

Simplify convexHull #249

tmcw opened this issue Sep 18, 2013 · 1 comment

Comments

@tmcw
Copy link
Contributor

tmcw commented Sep 18, 2013

It looks like QuickHull creates unnecessary structure in the hull generated and we could simply return a properly sorted & depth-of-one array here?
@danzel
Copy link
Member

danzel commented Sep 19, 2013

Yep definitely, I haven't revisited this code since getting it to work for our purposes.

@danzel danzel closed this as completed in 038f17f Oct 13, 2013
danzel added a commit that referenced this issue Oct 13, 2013
@danzel
Merge pull request #253 from tmcw/simple-hull
23dfa90 
Simplify QuickHull generation. Fixes #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @danzel