XeLaTeX support #291
Merged
XeLaTeX support #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relating to KristofferC#290.
|
LGTM, apologies for the delayed review. Please also update the Choosing the LaTeX engine used part of |
|
Also, apologies for the delayed reaction. Didn't see the review last week. |
KristofferC
reviewed
May 2, 2022
|
|
||
| """ | ||
| The active LaTeX engine. Initialized the first time [`latexengine`](@ref) is called. | ||
| """ | ||
| const ACTIVE_LATEX_ENGINE = Ref{Union{Nothing, LaTeXEngine}}(nothing) | ||
| function latexengine() | ||
| if ACTIVE_LATEX_ENGINE[] === nothing | ||
| for (engine, enum) in zip(("lualatex", "pdflatex"), (LUALATEX, PDFLATEX)) | ||
| for (engine, enum) in zip(("lualatex", "pdflatex", "xelatex"), (LUALATEX, PDFLATEX, XELATEX)) |
There was a problem hiding this comment.
Do we want to pick xelatex over pdflatex if we find it?
There was a problem hiding this comment.
I don't know much about XeLaTeX, so I would stick with the ordering above and leave it to the user to request something else.
tpapp
approved these changes
May 2, 2022
KristofferC
reviewed
May 2, 2022
Co-authored-by: Kristoffer Carlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #290.