Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation message] Remove MeshIndex from GetProperties #9994

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

miguelmaso
Copy link
Contributor

@miguelmaso miguelmaso commented Jun 30, 2022

📝 Description
Added message for #9774

🆕 Changelog

  • Added message to the List of upcoming API-breaking and behavior changes in CMakeLists

@miguelmaso miguelmaso added the Legacy Old code not maintained label Jun 30, 2022
@miguelmaso miguelmaso requested a review from a team as a code owner June 30, 2022 14:34
@loumalouomega
Copy link
Member

When do we plan to remove all MeshesIndex?, in fact, if we remove all we can store in the ModelPart a single mesh instead of a vector of Meshes, which will speed up a bit the access to the mesh. (and we do this all the time, so maybe at the end the speed up could be relevant)

@loumalouomega
Copy link
Member

When do we plan to remove all MeshesIndex?, in fact, if we remove all we can store in the ModelPart a single mesh instead of a vector of Meshes, which will speed up a bit the access to the mesh. (and we do this all the time, so maybe at the end the speed up could be relevant)

@KratosMultiphysics/technical-committee I can open an issue to discuss this in deep

@rubenzorrilla
Copy link
Member

Removing the MeshIndex at once is in my opinion a bit risky. Instead, I'd start promoting actions like the one in #9774, so we start removing it at a constant but slow pace. For doing so, it would be nice to have a sort of strategy so maybe it's worth to create such issue to discuss which are the steps.

@miguelmaso miguelmaso merged commit d547537 into master Aug 2, 2022
@miguelmaso miguelmaso deleted the core/properties-warning branch August 2, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Old code not maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants