Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pfem interface compatible with kratos master #139

Merged
merged 3 commits into from
Aug 2, 2017
Merged

pfem interface compatible with kratos master #139

merged 3 commits into from
Aug 2, 2017

Conversation

AFranci
Copy link
Member

@AFranci AFranci commented Aug 2, 2017

No description provided.

josep-m-carbonell
josep-m-carbonell approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@josep-m-carbonell josep-m-carbonell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please try it and make a simple test, i have noticed that fluids cross the walls, maybe some error has been introduced to the code. This comment is not related with the changes of this pull request.

@AFranci AFranci merged commit 84639e1 into master Aug 2, 2017
@AFranci AFranci deleted the feature-pfem-update branch August 2, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josep-m-carbonell josep-m-carbonell josep-m-carbonell approved these changes

@maceligueta maceligueta Awaiting requested review from maceligueta

@jginternational jginternational Awaiting requested review from jginternational

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AFranci @josep-m-carbonell @jginternational