Updating Python scripts #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python main scripts have been updated to make them as similar as possible between applications. A unique python script is used for both serial and parallel execution.
loumalouomega
requested changes
Jul 16, 2017
|
|
||
| # Import define_output | ||
| from KratosMultiphysics import * | ||
| from KratosMultiphysics.ExternalSolversApplication import * |
There was a problem hiding this comment.
A time ago we decided to do the import with * in the main scripts. However, I do not exactly remember why...
There was a problem hiding this comment.
i think that the argument was "simplicity". However in the solvers it should be used without the *
RiccardoRossi
previously approved these changes
Jul 17, 2017
| if (parallel_type == "OpenMP") or (mpi.rank == 0): | ||
| print("") | ||
| print(main_model_part) | ||
| for properties in main_model_part.Properties: |
There was a problem hiding this comment.
why do we want to print this? is it for debug purposes?
There was a problem hiding this comment.
Probably we can remove this one, or maybe print it when echo_level is larger than one (as is done with other print statements).
loumalouomega
previously approved these changes
Jul 17, 2017
rubenzorrilla
dismissed stale reviews from loumalouomega and RiccardoRossi
via
89209ff
|
Will this work with the Release branch? |
|
Indeed, this must be in the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python main scripts have been updated to make them as similar as possible between applications. A unique python script is used for both serial and parallel execution.