Constructor inheritance

[randombyte-developer]

I am running dukat version 0.0.28.

export class A {
  constructor(p1: string) { }
}

export class B extends A { }

produces

external open class A(p1: String)

external open class B : A

Is this correct? I think the class B should also have the constructor from A.

I just tried to start with Kotlin JS and use a JS library in Kotlin, but noticed that the type hints were wrong.

[Schahen]

Hi! I'm not sure, let's discuss.
Strictly speaking your code is out of scope of current kotlin functionality since it's not a declaration - as of now we support only declaration conversation.

So, let's modifiy slightly the example and consider this snippet of code:

declare class A {
  constructor(p1: string)
}

declare class B extends A { }

This is translated to (I'm omitting imports and annotations):

external open class A(p1: String)

external open class B : A

Which is perfectly valid in that sense that it will compile.
However! In typescript we can use A and B declarations following way:

function main() {
        let a = new A("HEY! I AM A");
        let b = new B("HI! I AM B");
}      

while in Kotlin this won't compile:

fun main() {
  val a = A("HEY! I AM A")
  val b = B("HI! I AM B")
}

So this do feels like a problem to me. Let me think about it for a while and double-check typescript specs.

If it is indeed a problem, it's definitely a major one - currently we check compilation errors but runtime errors will fly under our radars.

[randombyte-developer]

Sorry for the late reply.

The defintion file I wanted to use is https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/google.visualization/index.d.ts

There's a lot of inheritance going on, specifically the charts don't explicity define constructors but inherit them.
I think that this is something that should definitely be supported.

[Schahen]

Will be released in 0.5.8 now can be checked with dukat@next