Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kmodal): kmodal not scrollable when content slot used [KHCP-15360] #2635

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 5, 2025

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-15360

Fix issue in KModal where it's not scrollable vertically when content slot is used

@portikM portikM self-assigned this Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 11277a3
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67c8c69a1025a800088fbcef
😎 Deploy Preview https://deploy-preview-2635--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 11277a3
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67c8c69a8b93f50008c8e17b
😎 Deploy Preview https://deploy-preview-2635--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review March 5, 2025 22:01
@portikM portikM requested review from adamdehaven, jillztom, Justineo and a team as code owners March 5, 2025 22:01
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 2fb7dab into main Mar 5, 2025
10 checks passed
@portikM portikM deleted the fix/khcp-15360-kmodal-not-scrollable branch March 5, 2025 22:27
kongponents-bot pushed a commit that referenced this pull request Mar 5, 2025
## [9.22.2](v9.22.1...v9.22.2) (2025-03-05)

### Bug Fixes

* **kmodal:** kmodal not scrollable when content slot used [KHCP-15360] ([#2635](#2635)) ([2fb7dab](2fb7dab))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants