-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: more flexible extrinsic unwrapping for ctype fetching #837
Conversation
63257c9
to
065647b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your solution, very elegant. I am wondering if it can be structured a bit better with regards to functions responsibilities. Other than that, I like it a lot!
f7ec50f
to
a0455f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one more minor comment, otherwise it looks good.
ce3b258
to
4b30fd4
Compare
fixes https://github.com/KILTprotocol/ticket/issues/3119
While I hot fixed the current behaviour in #836 to allow extrinsics submitted via dispatchAs, I think it's a better strategy for the future to build on top of on an unwrapper function that returns nested calls contained within other extrinsics that can easily be amended. E.g., we could easily add unwrapping of proxy calls to the logic here and everything still works.
How to test:
Ideally, fetch a CType with it.
Checklist: