Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump node to v18 #833

Merged
merged 3 commits into from
Feb 6, 2024
Merged

chore(deps): bump node to v18 #833

merged 3 commits into from
Feb 6, 2024

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Feb 5, 2024

re https://github.com/KILTprotocol/ticket/issues/3081

Require at least node v18 (maintenance), CI uses node v20 (current). Testing against v16 has moved to optional.
https://nodejs.org/en/about/previous-releases

How to test:

CI should not break.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner marked this pull request as ready for review February 5, 2024 17:41
@rflechtner rflechtner requested a review from ntn-x2 February 5, 2024 17:41
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! I assume this is not a breaking change for downstream users? They would only get a warning if using a version < 18, right? Will this be released after SDK v1 is out?

@rflechtner
Copy link
Contributor Author

Very good! I assume this is not a breaking change for downstream users? They would only get a warning if using a version < 18, right? Will this be released after SDK v1 is out?

Depending on their config the package manager may error, but they should be able to disable that.
And yes, id say this gets released with v1, otherwise we'd have to backport (which we may have to do eventually anyway though)

@rflechtner rflechtner merged commit 727174d into develop Feb 6, 2024
15 checks passed
@rflechtner rflechtner deleted the rf-bump-node branch February 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants