Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all --sysimage-native-code=no cmdlineargs tests single-threaded #57445

Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 17, 2025

See #57198 which seems to have become more likely than it was back when #57087 was merged.
Expected to be a fix for

  | cmdlineargs                                      (4) \|         failed at 2025-02-17T09:00:29.886
  | Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-grannysmith-C07ZM05NJYVY.0/build/default-grannysmith-C
  | 07ZM05NJYVY-0/julialang/julia-master/julia-3e78f79786/share/julia/test/cmdlineargs.jl:1092
  | Expression: occursin(r"\.jl:(\d+)", bt)
  | Evaluated: occursin(r"\.jl:(\d+)", "Internal error: during type inference of\ntypeinf_ext_toplevel(Core.MethodInstance, UInt64, UInt8)\nEncountered unexpecte
  | d error in runtime:\nTypeError(func=:isa, context=\"\", expected=Type, got=\n[13758] signal 11: Segmentation fault: 11\nin expression starting at none:0\njl_is_
  | cpointer_type at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julial
  | ang/julia-master/src/./julia.h:1750 [inlined]\njl_static_show_x_ at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-m
  | acmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/rtutils.c:982\njl_static_show_next_ at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4
  | ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/rtutils.c:1391\njl_static_show_x at /Users/ju
  | lia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/rtuti
  | ls.c:1336 [inlined]\njl_static_show_x_ at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/defau
  | lt-macmini-x64-5-0/julialang/julia-master/src/rtutils.c:1302\njl_static_show_next_ at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/age
  | nt-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/rtutils.c:1391\njl_type_infer at /Users/julia/.julia/scratchspaces/a66
  | 863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:466\njl_compile_method_inter
  | nal at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-
  | master/src/gf.c:2972\n_jl_invoke at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-mac
  | mini-x64-5-0/julialang/julia-master/src/gf.c:3467 [inlined]\nijl_apply_generic at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-c
  | ache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:3675\njl_apply at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff
  | 4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/./julia.h:2300 [inlined]\njl_type_infer at /Use
  | rs/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/
  | gf.c:453\njl_compile_method_internal at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default
  | -macmini-x64-5-0/julialang/julia-master/src/gf.c:2972\n_jl_invoke at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-
  | macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:3467 [inlined]\nijl_apply_generic at /Users/julia/.julia/scratchspaces/a66863c6-20
  | e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:3675\njl_apply at /Users/julia/.juli
  | a/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/./julia.h:2300
  | [inlined]\njl_type_infer at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x6
  | 4-5-0/julialang/julia-master/src/gf.c:453\njl_compile_method_internal at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/defa
  | ult-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:2972\n_jl_invoke at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-
  | 49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:3467 [inlined]\nijl_apply_generic at /Users/julia
  | /.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/gf.c:367
  | 5\njl_apply at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialan
  | g/julia-master/src/./julia.h:2300 [inlined]\njl_module_run_initializer at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/def
  | ault-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/toplevel.c:75\n_finish_julia_init at /Users/julia/.julia/scratchspaces/a66863c6-20
  | e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/init.c:929\njulia_init at /Users/julia/.j
  | ulia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/src/init.c:864\
  | njl_repl_entrypoint at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/
  | julialang/julia-master/src/jlapi.c:1118\nAllocations: 1 (Pool: 1; Big: 0); GC: 0")

@IanButterworth IanButterworth force-pushed the ib/ci_single_thread_test branch 3 times, most recently from 709974a to c2dfdb4 Compare February 17, 2025 21:10
@IanButterworth IanButterworth changed the title Run cmdlineargs test single-threaded Run all --sysimage-native-code=no cmdlineargs test single-threaded Feb 17, 2025
@IanButterworth IanButterworth marked this pull request as ready for review February 17, 2025 21:10
@IanButterworth IanButterworth added multithreading Base.Threads and related functionality ci Continuous integration labels Feb 17, 2025
@IanButterworth IanButterworth force-pushed the ib/ci_single_thread_test branch 2 times, most recently from befe04a to cc2f17d Compare February 18, 2025 03:30
@IanButterworth IanButterworth force-pushed the ib/ci_single_thread_test branch from cc2f17d to c805d27 Compare February 18, 2025 03:30
@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Feb 18, 2025
@IanButterworth IanButterworth changed the title Run all --sysimage-native-code=no cmdlineargs test single-threaded Run all --sysimage-native-code=no cmdlineargs tests single-threaded Feb 18, 2025
@IanButterworth IanButterworth merged commit d43a5ad into JuliaLang:master Feb 18, 2025
10 checks passed
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 18, 2025
@IanButterworth IanButterworth deleted the ib/ci_single_thread_test branch February 18, 2025 20:05
@IanButterworth IanButterworth added the backport 1.12 Change should be backported to release-1.12 label Feb 18, 2025
KristofferC pushed a commit that referenced this pull request Feb 21, 2025
@KristofferC KristofferC mentioned this pull request Feb 21, 2025
24 tasks
KristofferC added a commit that referenced this pull request Feb 26, 2025
Backported PRs:
- [x] #57302 <!-- Add explicit imports for types and fix bugs -->
- [x] #57420 <!-- Compiler: Fix check for IRShow definedness -->
- [x] #57419 <!-- generated: Switch resolution module back to what it
was before -->
- [x] #57421 <!-- bpart: Skip implicit import reval if using'd export
set is unchanged -->
- [x] #57425 <!-- Prohibit binding replacement in closed modules during
precompile -->
- [x] #57426 <!-- Prohibit `import`ing or `using` Main during
incremental compilation -->
- [x] #57433 <!-- bpart: Track whether any binding replacement has
happened in image modules -->
- [x] #57445 <!-- Run all `--sysimage-native-code=no` cmdlineargs tests
single-threaded -->
- [x] #57386 <!-- Only strip invariant.load from special pointers -->
- [x] #57453 <!-- Revert "Make emitted egal code more loopy (#54121)"
-->
- [x] #57389 <!-- Change memory indexing to use the type as index
instead of i8 -->
- [x] #57447 <!-- Don't return null pointer when asking for the type of
a declared global -->
- [x] #57467 <!-- using/import: ensure world update after each
observable operation -->
- [x] #57471 <!-- staticdata: Don't use `newm` pointer after it has been
invalidated -->
- [x] #57416 <!-- lowering: Don't mutate lambda in `linearize` -->
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants