Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor bug displaying Inf instead of Inf16 #52093

Closed
wants to merge 7 commits into from
Closed

fix: minor bug displaying Inf instead of Inf16 #52093

wants to merge 7 commits into from

Conversation

masterujjval
Copy link
Contributor

@masterujjval masterujjval commented Nov 9, 2023 •
edited
Loading

#51087 tried to solve the issue and made some minor changes in the code
Screenshot from 2023-11-09 13-10-18

Screenshot from 2023-11-09 13-10-33

@KristofferC kindly review and guide me to remove that , that is after Inf16.

@giordano giordano added the needs tests Unit tests are required for this change label Nov 9, 2023
@KristofferC
Copy link
Member

This doesn't look right. It, for example, stops writing out the first argument now?

# Before
julia> UInt8(12332)
ERROR: InexactError: trunc(UInt8, 12332)

# After
julia> UInt8(12332)
ERROR: InexactError: trunc(12332,)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masterujjval @KristofferC @giordano