bail out call inference when return type is maximized #48878
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made the condition to bail out call inference a bit more strict in #48263 by looking at the inferred effects. It turns out that it slows down package loading time as reported at #48811. This commit simply remove the condition. In particular, the loading time of `CairoMakie` is reduced to 40s from 48s (on master). External `AbstractInterpreter` can use the current condition by overloading `bail_out_call`.
|
Can we look into what exactly is being inferred extra inside CairoMakie? I don't think it's necessarily sensible to base this on this one case alone. The problem with bailing here is that it can really poison the effects of something that could otherwise be concrete-eval-eligible for a massive inference slowdown. |
|
There's also the issue where we're no longer properly sorting the matches do do the ones most likely to bail first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made the condition to bail out call inference a bit more strict in #48263 by looking at the inferred effects. It turns out that it slows down package loading time as reported at #48811.
This commit simply remove the condition. In particular, the loading time of
CairoMakieis reduced to 40s from 48s (on master).External
AbstractInterpretercan use the current condition by overloadingbail_out_call.