Optimizations for diagonal HermOrSym
#48189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
force-pushed
the
dk/hermorsym
branch
from
19b7c79 to
99eee55
Compare
stevengj
reviewed
Jan 13, 2023
|
The factorization change is (not surprisingly) very beneficial, even for small matrices. |
stevengj
reviewed
Jan 15, 2023
|
I believe this is in good shape now. @stevengj Can you please take another look? |
dkarrasch
changed the title
HermOrSymHermOrSym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added checks should generically fail quickly, but the benefits of performance in the diagonal case are presumably dramatic. Somewhat related to JuliaLang/LinearAlgebra.jl#922.