-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update MPFR to 4.2.0 #48165
update MPFR to 4.2.0 #48165
Conversation
7b80058
to
13c71b4
Compare
Should add tests for the new methods? |
I think it should be covered by tests in |
Hmm, looks like not. I'll update them |
Possibly you want to define e.g. tanpi since it's already implemented there: "mpfr_tanpi, mpfr_acospi, mpfr_asinpi, mpfr_atanpi and mpfr_atan2pi"? It seems trivial to add, for MPFR (though not for Float64). It's not yet in Base for floats, but [a]tabpi is in C2x standard (and IEEE 754:2019 and C#/dotnet seems to implemente it, issue 20137 there): https://grouper.ieee.org/groups/msc/ANSI_IEEE-Std-754-2019/background/tanpi.txt
I see that you want to bring MPFR support in line with Base (floats), to be fully generic, so it's less than ideal to only have some functions for big/MPFR, not regular floats... the opposite problem, but we want to implement those at least eventually. We could actually do it by calling MPFR and then truncate to e.g. Float64? So not fast but could be improved later... |
I'm just adding methods to functions which are already are defined in Base, and which have corresponding functions that were added to MPFR in this release. I think adding the additional functions to Base is a good idea, but should be a separate PR |
Not sure if we want to backport or not? |
why would we backport? This looks to me a lot like a new feature. |
Updating the library could be backported but adding methods should not. |
It doesn't look like there are any important bug fixes: https://www.mpfr.org/mpfr-4.2.0/#changes (their printing fix actually broke our printing, hence the change in this PR) |
Wow, all green CI! Haven't seen that recently. |
Updates MPFR library, and makes use of new trig functions