Constprop split_rest on tuple and namedtuple #47328
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia 1.9 adds Base.split_rest, which can be used to slurp in non-final positions. However, unlike slurping in the final position, split_rest does not constant propagate, causing type instability in a pattern like
head..., tail = args::Tuple
.This PR adds
@constprop :aggressive
to split_rest for tuples and named tuples, and tests that it constant folds as expected.Issue discovered by @sgaure and fix proposed by @simeonschaub.
Closes #47326