Add nospecialize to methodswith #47302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On current master, calling methodswith compiles a new specialization for each type being checked, which easily runs into the hundreds of specializations, completely unnecessarily. This PR adds a bunch of nospecialize statements to methodswith to reduce latency significantly.
|
Test failures seem to be due to some kind of network error. I don't think they're related. |
|
Looks quite sensible, and the time to second methodswith doesn't increase according to Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current master, calling methodswith compiles a new specialization for each type being checked, which easily runs into the hundreds of specializations, completely unnecessarily.
This PR adds a bunch of nospecialize statements to methodswith to reduce latency significantly - by about a factor of 7 on my laptop.
Improves #43468 quite significantly - though might not completely solve it. On my computer,
methodswith(String)takes about 450 ms on Julia 1.0, and 485 ms with this PR, compared to 3.5-5.5 seconds on Julia 1.8.2.