Make sure to preserve info in union-split #47301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Oct 24, 2022
Keno
force-pushed
the
kf/unionsplitinfo
branch
from
c66e589 to
457ea43
Compare
Generally we try pretty hard in inlining to make sure to preserve the :info of a statement when we turn it into :invoke. We don't use this information in the compiler itself, but it is used by external tools (including Cthulhu). However, we were dropping this info during union splitting for no particular reason. Fix that.
Keno
force-pushed
the
kf/unionsplitinfo
branch
from
457ea43 to
1525754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally we try pretty hard in inlining to make sure to preserve the :info of a statement when we turn it into :invoke. We don't use this information in the compiler itself, but it is used by external tools (including Cthulhu). However, we were dropping this info during union splitting for no particular reason. Fix that.