Fix various oracle check failures #47289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Oct 22, 2022
base/compiler/utilities.jl
Outdated
| @@ -337,6 +337,16 @@ function foreachssa(@specialize(f), @nospecialize(stmt)) | |||
| end | |||
| end | |||
|
|
|||
| function foreachanyssa(@specialize(f), @nospecialize(stmt)) | |||
There was a problem hiding this comment.
Suggested change
| function foreachanyssa(@specialize(f), @nospecialize(stmt)) | |
| function foreach_anyssa(@specialize(f), @nospecialize(stmt)) |
maybe?
There was a problem hiding this comment.
Probably makes sense just to spell these as foreach(f, anyssas(stmt)) and foreach(f, ssas(stmt)) rather than making separate functions.
There was a problem hiding this comment.
Actually, scratch that. The compiler isn't currently good enough to do that without allocations. I'll just do what you suggested here.
Also make the oracle check work while there are still new_new_nodes, which helps generate oracle check failures closer to where the actual issue is.
We weren't accounting for the removed use when inlining a constant argtype into a GotoIfNot node.
Keno
force-pushed
the
kf/oraclefailures
branch
from
8b93bae to
b809e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while debugging other miscompiles. These are both overcounts, so shouldn't have caused any bugs (just sub-optimalities), but it's generally good to fix these anyway so that the oracle check becomes more useful for finding actual issues.